Linus Torvalds Rejects Code, Highlights Kernel Growth Standards
Linus Torvalds, the creator of Linux, recently delivered a sharp rebuke to a kernel developer over a late and, in his view, poorly constructed code submission. The incident underscores the rigorous standards Torvalds maintains for the Linux kernel and offers insight into the pressures of maintaining a massive open-source project.
Torvalds had previously warned developers that the merge window for Linux 6.17 would be “slightly chaotic” due to personal commitments – a wedding and a notable birthday involving travel between the US and Finland. He explicitly requested early pull requests, anticipating his limited availability. Despite this, Meta software engineer Palmer Dabbelt submitted a set of RISC-V patches late.
The response was swift and direct. Torvalds labeled the submission “garbage” and criticized its timing, stating it arrived “too late.” He emphasized the importance of submitting high-quality code, especially when developers are aware of his schedule constraints.
Specific Concerns with the Code
Torvalds’ criticism wasn’t limited to the late submission. He pinpointed several technical issues, including:
Unnecessary Complexity: A helper function combining two 16-bit integers into a 32-bit integer was deemed “crazy and pointless.” Torvalds argued it actively made the code worse and harder to understand.
Scope of Changes: The code introduced changes to generic header files, impacting the broader Linux ecosystem beyond the RISC-V architecture. This concerned Torvalds, who stressed the importance of keeping architecture-specific code isolated.
Overall quality: He repeatedly used the term “garbage” to describe the code, emphasizing its lack of value and potential to introduce problems.
“That thing makes the world actively a worse place to live,” Torvalds wrote, demonstrating the intensity of his disapproval. He further stated the helper function was “useless garbage” and actively detrimental to code comprehension.
The Importance of Kernel Development Standards
This incident highlights the critical role of code quality and adherence to established standards in kernel development. The Linux kernel, powering countless devices and systems, demands a high level of reliability and maintainability.
Here’s why thes standards matter to you, even if you aren’t a kernel developer:
Stability: Rigorous code review and rejection of substandard submissions contribute to the overall stability of the operating system.
Security: Clean, well-understood code is less prone to vulnerabilities.
maintainability: Clear code makes it easier for developers to fix bugs and add new features in the future.
Community Collaboration: Consistent standards foster effective collaboration within the open-source community.
Dabbelt’s Response and Lessons Learned
Dabbelt quickly acknowledged his mistake and apologized for the late and subpar submission. He admitted to “dropping the ball” and vowed to improve his process to avoid similar issues in the future.
this exchange serves as a reminder to all developers – especially those contributing to large open-source projects – of the importance of:
Respecting Maintainer schedules: Pay attention to announced timelines and constraints.
Prioritizing Code Quality: Ensure your submissions are well-written, thoroughly tested, and adhere to project standards.
Understanding project Scope: Be mindful of the impact your changes may have on other parts of the codebase.
Ultimately,Torvalds’ strong reaction,while direct,is a testament to his dedication to maintaining the integrity and quality of the Linux kernel. It reinforces the message that contributing to this vital project requires a commitment to excellence.
